[lkml]   [2021]   [Jul]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 16/23] iommu/arm-smmu: Prepare for multiple DMA domain types
On 2021-07-26 13:46, Joerg Roedel wrote:
> On Wed, Jul 21, 2021 at 07:20:27PM +0100, Robin Murphy wrote:
>> - if (type == IOMMU_DOMAIN_DMA && using_legacy_binding)
>> + if ((type & __IOMMU_DOMAIN_DMA_API) && using_legacy_binding)
> Hmm, I wonder whether it is time to introduce helpers for these checks?
> Something like iommu_domain_is_dma() is more readable.

Ha, I had exactly that at one point, except I think in the order of
iommu_is_dma_domain() :)

The end result didn't seem to give enough extra clarity to justify the
header churn for me, but I'm happy to be wrong about that if you prefer.


 \ /
  Last update: 2021-07-26 15:10    [W:0.064 / U:2.404 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site