Messages in this thread |  | | From | Shai Malin <> | Subject | RE: [PATCH] net: qed: remove unneeded return variables | Date | Mon, 26 Jul 2021 12:21:09 +0000 |
| |
On Sunday, July 25, 2021 6:14 PM, Jason Wang <wangborong@cdjrlc.com> wrote: > Some return variables are never changed until function returned. > These variables are unneeded for their functions. Therefore, the unneeded > return variables can be removed safely by returning their initial values. > > Signed-off-by: Jason Wang <wangborong@cdjrlc.com> > --- > drivers/net/ethernet/qlogic/qed/qed_dcbx.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/net/ethernet/qlogic/qed/qed_dcbx.c > b/drivers/net/ethernet/qlogic/qed/qed_dcbx.c > index e81dd34a3cac..dc93ddea8906 100644 > --- a/drivers/net/ethernet/qlogic/qed/qed_dcbx.c > +++ b/drivers/net/ethernet/qlogic/qed/qed_dcbx.c > @@ -741,7 +741,6 @@ static int > qed_dcbx_read_local_lldp_mib(struct qed_hwfn *p_hwfn, struct qed_ptt > *p_ptt) { > struct qed_dcbx_mib_meta_data data; > - int rc = 0; > > memset(&data, 0, sizeof(data)); > data.addr = p_hwfn->mcp_info->port_addr + offsetof(struct > public_port, @@ -750,7 +749,7 @@ qed_dcbx_read_local_lldp_mib(struct > qed_hwfn *p_hwfn, struct qed_ptt *p_ptt) > data.size = sizeof(struct lldp_config_params_s); > qed_memcpy_from(p_hwfn, p_ptt, data.lldp_local, data.addr, > data.size); > > - return rc; > + return 0; > } > > static int > @@ -810,7 +809,6 @@ static int > qed_dcbx_read_local_mib(struct qed_hwfn *p_hwfn, struct qed_ptt > *p_ptt) { > struct qed_dcbx_mib_meta_data data; > - int rc = 0; > > memset(&data, 0, sizeof(data)); > data.addr = p_hwfn->mcp_info->port_addr + @@ -819,7 +817,7 @@ > qed_dcbx_read_local_mib(struct qed_hwfn *p_hwfn, struct qed_ptt > *p_ptt) > data.size = sizeof(struct dcbx_local_params); > qed_memcpy_from(p_hwfn, p_ptt, data.local_admin, data.addr, > data.size); > > - return rc; > + return 0; > } > > static int qed_dcbx_read_mib(struct qed_hwfn *p_hwfn, > -- > 2.32.0
Thanks!
Acked-by: Shai Malin <smalin@marvell.com>
|  |