Messages in this thread Patch in this message |  | | From | Jan Kiszka <> | Subject | [PATCH] watchdog: iTCO_wdt: Fix detection of SMI-off case | Date | Mon, 26 Jul 2021 13:46:13 +0200 |
| |
From: Jan Kiszka <jan.kiszka@siemens.com>
Obviously, the test needs to run against the register content, not its address.
Fixes: cb011044e34c ("watchdog: iTCO_wdt: Account for rebooting on second timeout") Reported-by: Mantas Mikulėnas <grawity@gmail.com> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com> --- drivers/watchdog/iTCO_wdt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/watchdog/iTCO_wdt.c b/drivers/watchdog/iTCO_wdt.c index b3f604669e2c..643c6c2d0b72 100644 --- a/drivers/watchdog/iTCO_wdt.c +++ b/drivers/watchdog/iTCO_wdt.c @@ -362,7 +362,7 @@ static int iTCO_wdt_set_timeout(struct watchdog_device *wd_dev, unsigned int t) * Otherwise, the BIOS generally reboots when the SMI triggers. */ if (p->smi_res && - (SMI_EN(p) & (TCO_EN | GBL_SMI_EN)) != (TCO_EN | GBL_SMI_EN)) + (inl(SMI_EN(p)) & (TCO_EN | GBL_SMI_EN)) != (TCO_EN | GBL_SMI_EN)) tmrval /= 2; /* from the specs: */ -- 2.26.2
|  |