lkml.org 
[lkml]   [2021]   [Jul]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [v3 5/5] soc: mediatek: pm-domains: Remove unused macro
From
Date
On Thu, 2021-07-15 at 14:40 +0800, Chen-Yu Tsai wrote:
> On Mon, Jul 5, 2021 at 1:48 PM Chun-Jie Chen <
> chun-jie.chen@mediatek.com> wrote:
> >
> > Due to clk resource data will be allocated dynamically by
> > searching parent count of clk in power domain node, so remove
> > the unused marco MAX_SUBSYS_CLKS for static allocation.
> >
> > Signed-off-by: Chun-Jie Chen <chun-jie.chen@mediatek.com>
> > Reviewed-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
> > ---
> > drivers/soc/mediatek/mtk-pm-domains.h | 2 --
> > 1 file changed, 2 deletions(-)
> >
> > diff --git a/drivers/soc/mediatek/mtk-pm-domains.h
> > b/drivers/soc/mediatek/mtk-pm-domains.h
> > index caaa38100093..1b8967b9829e 100644
> > --- a/drivers/soc/mediatek/mtk-pm-domains.h
> > +++ b/drivers/soc/mediatek/mtk-pm-domains.h
> > @@ -72,8 +72,6 @@ struct scpsys_bus_prot_data {
> > bool ignore_clr_ack;
> > };
> >
> > -#define MAX_SUBSYS_CLKS 10
> > -
>
> Future advice: cleanups like this and other fixes should be put in
> the
> front of the series, before any patches that introduce support for
> new
> features or hardware. That way if the new code still needs work,
> maintainers can optionally apply the fixes so you don't have to carry
> a large patch series forward.
>
> ChenYu
>
Ok, I will re-order the patches in next series.
Thanks for your comment.

Best Regards,
Chun-Jie

> > /**
> > * struct scpsys_domain_data - scp domain data for power on/off
> > flow
> > * @name: The name of the power domain.
> > --
> > 2.18.0
> > _______________________________________________
> > Linux-mediatek mailing list
> > Linux-mediatek@lists.infradead.org
> >
https://urldefense.com/v3/__http://lists.infradead.org/mailman/listinfo/linux-mediatek__;!!CTRNKA9wMg0ARbw!2l_6i-Mdrf270eVKoo59clCnOVZoi5wlBEuHFAfriTvaSsrv6Loc8HJbt7K8LexIJWuR$
> >
\
 
 \ /
  Last update: 2021-07-26 13:33    [W:0.049 / U:0.560 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site