[lkml]   [2021]   [Jul]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [RFC PATCH 01/12] afs: Sort out symlink reading
Jeff Layton <> wrote:

> > -static int afs_symlink_readpage(struct page *page)
> > +static int afs_symlink_readpage(struct file *file, struct page *page)
> > {
> > struct afs_vnode *vnode = AFS_FS_I(page->mapping->host);
> > struct afs_read *fsreq;
> I wonder...would you be better served here by not using page_readlink
> for symlinks and instead use simple_get_link and roll your own readlink
> operation. It seems a bit more direct, and AFS seems to be the only
> caller of page_readlink.

Maybe. At some point it will need to go through netfs_readpage() so that it
will get cached and maybe encrypted. Possibly there should be a
netfs_readlink(). AFS directories too will at some point need to go through
netfs_readahead() or similar.


 \ /
  Last update: 2021-07-26 11:45    [W:0.127 / U:1.556 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site