Messages in this thread |  | | From | Stephen Boyd <> | Date | Mon, 26 Jul 2021 19:02:05 -0400 | Subject | Re: [PATCH] interconnect: qcom: osm-l3: Use driver-specific naming |
| |
Quoting Bjorn Andersson (2021-07-24 20:14:14) > In situations were the developer screws up by e.g. not giving the OSM > nodes unique identifiers the interconnect framework might mix up nodes > between the OSM L3 provider and e.g. the RPMh provider. > > The resulting callstack containts "qcom_icc_set", which is not unique to > the OSM L3 provider driver. Once the faulting qcom_icc_set() is > identified it's further confusing that "qcom_icc_node" is different > between the different drivers. > > To avoid this confusion, rename the node struct and the setter in the > OSM L3 driver to include "osm_l3" in their names. > > Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org> > ---
Thanks
Reviewed-by: Stephen Boyd <swboyd@chromium.org>
|  |