lkml.org 
[lkml]   [2021]   [Jul]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2 1/3] base: mark 'no_warn' as unused
From
Date
+ Greg and Rafael as the maintainer and reviewer of 
drivers/base/module.c respectively, drop everyone else.

Original post:

https://lore.kernel.org/r/20210726201924.3202278-2-morbo@google.com/

On 7/26/2021 1:19 PM, 'Bill Wendling' via Clang Built Linux wrote:
> Fix the following build warning:
>
> drivers/base/module.c:36:6: error: variable 'no_warn' set but not used [-Werror,-Wunused-but-set-variable]
> int no_warn;
>
> This variable is used to remove another warning, but causes a warning
> itself. Mark it as 'unused' to avoid that.
>
> Signed-off-by: Bill Wendling <morbo@google.com>

Even though they evaluate to the same thing, it might be worth using
"__always_unused" here because it is :)

Regardless:

Reviewed-by: Nathan Chancellor <nathan@kernel.org>

> ---
> drivers/base/module.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/base/module.c b/drivers/base/module.c
> index 46ad4d636731..10494336d601 100644
> --- a/drivers/base/module.c
> +++ b/drivers/base/module.c
> @@ -33,7 +33,7 @@ static void module_create_drivers_dir(struct module_kobject *mk)
> void module_add_driver(struct module *mod, struct device_driver *drv)
> {
> char *driver_name;
> - int no_warn;
> + int __maybe_unused no_warn;
> struct module_kobject *mk = NULL;
>
> if (!drv)
>

\
 
 \ /
  Last update: 2021-07-26 22:48    [W:0.121 / U:2.192 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site