[lkml]   [2021]   [Jul]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRE: [PATCH net-next RESEND 2/2] r8152: separate the r8152.c into r8152_main.c and r8152_fw.c
Greg KH <>
> Sent: Monday, July 26, 2021 3:37 PM
> That is a lot of different things all happening in one commit, why?

I plan to separate the file into two files. And
I find I need an additional header file for it, so
The patch includes adding that header file.

> Please break this up into "one patch per change" and submit it that way.
> But the real question is why break this file up in the first place?
> What is wrong with the way it is today? What future changes require
> this file to be in smaller pieces? If none, why make this? If there
> are future changes, then please submit this change when you submit
> those, as that would show a real need.

The purpose is let me easy to maintain the driver.
The code is larger and larger. And I find that the
r8169.c has been separated into three files.
Therefore, I think maybe I could split the driver
into small parts like r8169. Then, the code wouldn't
be complex.

Should I abandon these patches?

Best Regards,

 \ /
  Last update: 2021-07-26 10:29    [W:0.056 / U:0.552 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site