Messages in this thread |  | | Subject | Re: [PATCH v7 1/2] firmware_loader: use -ETIMEDOUT instead of -EAGAIN in fw_load_sysfs_fallback | From | Shuah Khan <> | Date | Mon, 26 Jul 2021 10:56:54 -0600 |
| |
On 7/24/21 6:11 AM, Anirudh Rayabharam wrote: > The only motivation for using -EAGAIN in commit 0542ad88fbdd81bb > ("firmware loader: Fix _request_firmware_load() return val for fw load > abort") was to distinguish the error from -ENOMEM, and so there is no > real reason in keeping it. -EAGAIN is typically used to tell the > userspace to try something again and in this case re-using the sysfs > loading interface cannot be retried when a timeout happens, so the > return value is also bogus. > > -ETIMEDOUT is received when the wait times out and returning that > is much more telling of what the reason for the failure was. So, just > propagate that instead of returning -EAGAIN. > > Suggested-by: Luis Chamberlain <mcgrof@kernel.org> > Signed-off-by: Anirudh Rayabharam <mail@anirudhrb.com> > --- > drivers/base/firmware_loader/fallback.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/base/firmware_loader/fallback.c b/drivers/base/firmware_loader/fallback.c > index 91899d185e31..1a48be0a030e 100644 > --- a/drivers/base/firmware_loader/fallback.c > +++ b/drivers/base/firmware_loader/fallback.c > @@ -535,8 +535,6 @@ static int fw_load_sysfs_fallback(struct fw_sysfs *fw_sysfs, long timeout) > if (fw_state_is_aborted(fw_priv)) { > if (retval == -ERESTARTSYS) > retval = -EINTR; > - else > - retval = -EAGAIN; > } else if (fw_priv->is_paged_buf && !fw_priv->data) > retval = -ENOMEM; > >
Reviewed-by: Shuah Khan <skhan@linuxfoundation.org>
thanks, -- Shuah
|  |