Messages in this thread |  | | From | Arnd Bergmann <> | Date | Mon, 26 Jul 2021 10:11:32 +0200 | Subject | Re: [PATCH V3 2/5] dt-bindings: i2c: Add bindings for i2c-virtio |
| |
On Mon, Jul 26, 2021 at 10:06 AM Arnd Bergmann <arnd@kernel.org> wrote: > > On Mon, Jul 26, 2021 at 6:52 AM Viresh Kumar <viresh.kumar@linaro.org> wrote: > > > > This patch adds binding for virtio I2C device, it is based on > > virtio-device bindings. > > > > Acked-by: Wolfram Sang <wsa@kernel.org> > > Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org> > > Reviewed-by: Arnd Bergmann <arnd@arndb.de>
Too quick, after seeing the same issue in the gpio binding I saw it here too:
> + i2c-virtio { > + compatible = "virtio,22";
The node name "i2c-virtio" looks wrong. According to https://github.com/devicetree-org/dt-schema/blob/master/schemas/i2c/i2c-controller.yaml, this needs to be plain "i2c".
Arnd
|  |