Messages in this thread Patch in this message |  | | From | Robert Foss <> | Subject | [PATCH v1 1/4] media: camss: vfe: Don't read hardware version needlessly | Date | Mon, 26 Jul 2021 10:01:10 +0200 |
| |
vfe_set_power() is invoced a few times, which causes a lot of VFE HW version prints.
Secondly there is no real reason for calling hw_version_read() from this location specifically, since it does nothing more than print the VFE HW version.
A better location for the hw_version_read() call would be somewhere which is only executed once per VFE unit.
Signed-off-by: Robert Foss <robert.foss@linaro.org> --- drivers/media/platform/qcom/camss/camss-vfe.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/media/platform/qcom/camss/camss-vfe.c b/drivers/media/platform/qcom/camss/camss-vfe.c index e0f3a36f3f3f..f6e889c1598e 100644 --- a/drivers/media/platform/qcom/camss/camss-vfe.c +++ b/drivers/media/platform/qcom/camss/camss-vfe.c @@ -713,8 +713,6 @@ static int vfe_set_power(struct v4l2_subdev *sd, int on) ret = vfe_get(vfe); if (ret < 0) return ret; - - vfe->ops->hw_version_read(vfe, vfe->camss->dev); } else { vfe_put(vfe); } @@ -1301,6 +1299,7 @@ int msm_vfe_subdev_init(struct camss *camss, struct vfe_device *vfe, return -EINVAL; } vfe->ops->subdev_init(dev, vfe); + vfe->ops->hw_version_read(vfe, dev); /* Memory */ -- 2.29.2
|  |