Messages in this thread |  | | From | Linus Torvalds <> | Date | Fri, 23 Jul 2021 16:40:22 -0700 | Subject | Re: [PATCH v3 1/7] iov_iter: Introduce fault_in_iov_iter helper |
| |
On Fri, Jul 23, 2021 at 1:58 PM Andreas Gruenbacher <agruenba@redhat.com> wrote: > > Introduce a new fault_in_iov_iter helper for manually faulting in an iterator. > Other than fault_in_pages_writeable(), this function is non-destructive.
Again, as I pointed out in the previous version, "Other than" is not sensible language.
You mean "Unlike".
Same issue in the comment:
> + * Other than fault_in_pages_writeable(), this function is non-destructive even > + * when faulting in pages for writing.
It really should be
"Unlike fault_in_pages_writeable(), this function .."
to parse correctly.
I understand what you mean, but only because I know what fault_in_pages_writeable() does and what the issue was.
And in a year or two, I might have forgotten, and wonder what you meant.
Linus
|  |