lkml.org 
[lkml]   [2021]   [Jul]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v3 4/7] iomap: Fix iomap_dio_rw return value for user copies
    Date
    When a user copy fails in one of the helpers of iomap_dio_rw, fail with -EFAULT
    instead of returning 0. This matches what iomap_dio_bio_actor already returns
    when it gets an -EFAULT from bio_iov_iter_get_pages.

    Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com>
    ---
    fs/iomap/direct-io.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/fs/iomap/direct-io.c b/fs/iomap/direct-io.c
    index 9398b8c31323..cc0b4bc8861b 100644
    --- a/fs/iomap/direct-io.c
    +++ b/fs/iomap/direct-io.c
    @@ -370,7 +370,7 @@ iomap_dio_hole_actor(loff_t length, struct iomap_dio *dio)
    {
    length = iov_iter_zero(length, dio->submit.iter);
    dio->size += length;
    - return length;
    + return length ?: -EFAULT;
    }

    static loff_t
    @@ -397,7 +397,7 @@ iomap_dio_inline_actor(struct inode *inode, loff_t pos, loff_t length,
    copied = copy_to_iter(iomap->inline_data + pos, length, iter);
    }
    dio->size += copied;
    - return copied;
    + return copied ?: -EFAULT;
    }

    static loff_t
    --
    2.26.3
    \
     
     \ /
      Last update: 2021-07-23 22:59    [W:8.577 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site