Messages in this thread |  | | Date | Thu, 22 Jul 2021 15:02:09 +0200 | From | Christoph Hellwig <> | Subject | Re: [PATCH v3 7/9] asm-generic: uaccess: remove inline strncpy_from_user/strnlen_user |
| |
On Thu, Jul 22, 2021 at 02:48:12PM +0200, Arnd Bergmann wrote: > From: Arnd Bergmann <arnd@arndb.de> > > The inline version is used on three NOMMU architectures and is > particularly inefficient when it scans the string one byte at a time > twice. It also lacks a check for user_addr_max(), but this is > probably ok on NOMMU targets. > > Consolidate the asm-generic implementation with the library version > that is used everywhere else. This version is generalized enough to > work efficiently on both MMU and NOMMU targets, and using the > same code everywhere reduces the potential for subtle bugs. > > Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org> > Acked-by: Geert Uytterhoeven <geert@linux-m68k.org> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
|  |