lkml.org 
[lkml]   [2021]   [Jul]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2] dt-bindings: display/panel: Add Innolux EJ030NA
On Sat, Jul 10, 2021 at 11:21:56AM +0100, Paul Cercueil wrote:
>
> [...]
>
> > > I am not sure; the doc states that this (additionalProperties:
> > > false) "can't
> > > be used in case where another schema is referenced", which is the
> > > case here,
> > > as we include "panel-common.yaml".
> >
> > This DT schema already list all relevant properties like:
> >
> > backlight: true
> >
> > So "additionalProperties: false" tells that no other properties are
> > allowed other than the listed properties.
> >
> > To my best understanding unevaluatedProperties: false is less strict and
> > should be used if one does not list all possilbe properties.

Right. There's some value of listing which common properties you are
using as well.

> > This could be the case for a panel haging below a SPI controller as in
> > this case. So in other words giving this some extra thought I think
> > unevaluatedProperties: false is OK here.
>
> A panel below a SPI controller would have all its SPI-specific properties
> covered by spi-controller.yaml, I believe? So maybe "additionalProperties:
> false" would work?

No. Because spi-controller.yaml is evaluated on the SPI host node and
this one is evaluated on the SPI slave. There's some work to address
this, but it means every SPI slave will have to reference a SPI device
schema. The bigger issue here is SPI controller specific device
properties. So for this case, we'll have to use unevaluatedProperties.

>
> In any case, if I use "additionalProperties: false", "make dt_binding_check"
> complains that my example's "spi-max-frequency" property is not covered. So
> maybe you are right.
>
> > So my r-b is ok if you keep it as it.
> >
> > PS. Where do you guys hang out with the downfall of freenode - somewhere
> > on oftc?
>
> We moved to #opendingux on Libera.
>
> Cheers,
> -Paul
>
>
>

\
 
 \ /
  Last update: 2021-07-14 22:30    [W:0.057 / U:0.528 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site