lkml.org 
[lkml]   [2021]   [Jul]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] drm/dp: Move panel DP AUX backlight support to drm_dp_helper
Hi,

On Sat, Jul 10, 2021 at 3:29 AM <rajeevny@codeaurora.org> wrote:
>
> > @@ -209,18 +208,11 @@ static inline int
> > of_drm_get_panel_orientation(const struct device_node *np,
> > #if IS_ENABLED(CONFIG_DRM_PANEL) &&
> > (IS_BUILTIN(CONFIG_BACKLIGHT_CLASS_DEVICE) || \
> > (IS_MODULE(CONFIG_DRM) && IS_MODULE(CONFIG_BACKLIGHT_CLASS_DEVICE)))
>
> Thanks, for the fix. Changes look good to me. I checked this on Trogdor
> Lazor device.
>
> I have one small doubt, shouldn't we add above (or similar) check around
> drm_panel_dp_aux_backlight() in drm_dp_helper source & header files?
> This function is using devm_backlight_device_register() that needs
> CONFIG_BACKLIGHT_CLASS_DEVICE for compilation.
>
> If that's not an issue,
> Reviewed-by: Rajeev Nandan <rajeevny@codeaurora.org>

Indeed you are correct. I tried trying off the
CONFIG_BACKLIGHT_CLASS_DEVICE and it was unhappy. I've posted a v2
which I think fixes this [1]. I left your review tag off to give you a
chance to confirm I didn't goof anything else up in the v2. Thanks!

[1] https://lore.kernel.org/lkml/20210712075933.v2.1.I23eb4cc5a680341e7b3e791632a635566fa5806a@changeid/

-Doug

\
 
 \ /
  Last update: 2021-07-12 17:08    [W:0.040 / U:0.084 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site