lkml.org 
[lkml]   [2021]   [Jul]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 5.12 36/43] ACPI: video: Add quirk for the Dell Vostro 3350
    Date
    From: Hans de Goede <hdegoede@redhat.com>

    [ Upstream commit 9249c32ec9197e8d34fe5179c9e31668a205db04 ]

    The Dell Vostro 3350 ACPI video-bus device reports spurious
    ACPI_VIDEO_NOTIFY_CYCLE events resulting in spurious KEY_SWITCHVIDEOMODE
    events being reported to userspace (and causing trouble there).

    Add a quirk setting the report_key_events mask to
    REPORT_BRIGHTNESS_KEY_EVENTS so that the ACPI_VIDEO_NOTIFY_CYCLE
    events will be ignored, while still reporting brightness up/down
    hotkey-presses to userspace normally.

    BugLink: https://bugzilla.redhat.com/show_bug.cgi?id=1911763
    Signed-off-by: Hans de Goede <hdegoede@redhat.com>
    Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/acpi/acpi_video.c | 9 +++++++++
    1 file changed, 9 insertions(+)

    diff --git a/drivers/acpi/acpi_video.c b/drivers/acpi/acpi_video.c
    index 2ea1781290cc..1b68d116d808 100644
    --- a/drivers/acpi/acpi_video.c
    +++ b/drivers/acpi/acpi_video.c
    @@ -540,6 +540,15 @@ static const struct dmi_system_id video_dmi_table[] = {
    DMI_MATCH(DMI_PRODUCT_NAME, "Vostro V131"),
    },
    },
    + {
    + .callback = video_set_report_key_events,
    + .driver_data = (void *)((uintptr_t)REPORT_BRIGHTNESS_KEY_EVENTS),
    + .ident = "Dell Vostro 3350",
    + .matches = {
    + DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
    + DMI_MATCH(DMI_PRODUCT_NAME, "Vostro 3350"),
    + },
    + },
    /*
    * Some machines change the brightness themselves when a brightness
    * hotkey gets pressed, despite us telling them not to. In this case
    --
    2.30.2
    \
     
     \ /
      Last update: 2021-07-11 02:11    [W:3.285 / U:0.344 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site