lkml.org 
[lkml]   [2021]   [Jul]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v1 08/17] drm/mediatek: Add component_del in OVL remove function
From
Date
On Wed, 2021-07-07 at 13:12 +0800, CK Hu wrote:
> Hi, Jason:
>
> On Wed, 2021-07-07 at 12:12 +0800, jason-jh.lin wrote:
> > Add component_del in OVL remove function.
> >
> > Signed-off-by: jason-jh.lin <jason-jh.lin@mediatek.com>
> > ---
> > drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/mediatek/mtk_disp_ovl.c
> > b/drivers/gpu/drm/mediatek/mtk_disp_ovl.c
> > index 99c39487026d..7504e86b167a 100644
> > --- a/drivers/gpu/drm/mediatek/mtk_disp_ovl.c
> > +++ b/drivers/gpu/drm/mediatek/mtk_disp_ovl.c
> > @@ -158,7 +158,6 @@ void mtk_ovl_stop(struct device *dev)
> > reg = reg & ~OVL_LAYER_SMI_ID_EN;
> > writel_relaxed(reg, ovl->regs +
> > DISP_REG_OVL_DATAPATH_CON);
> > }
> > -
>
> This modification is not related to this patch, so move out of this
> patch.
>
Hi CK,

OK, I'll remove this patch at the next version.

Regard,
Jason-JH.Lin
> > }
> >
> > void mtk_ovl_config(struct device *dev, unsigned int w,
> > @@ -424,6 +423,8 @@ static int mtk_disp_ovl_probe(struct
> > platform_device *pdev)
> >
> > static int mtk_disp_ovl_remove(struct platform_device *pdev)
> > {
> > + component_del(&pdev->dev, &mtk_disp_ovl_component_ops);
> > +
>
> This is a fix-up of patch [1]. Change this patch to fix all sub
> drivers,
> add Fixes tag, and move this patch out of this series. (This fix-up
> is
> not related to mt8195, so send this patch independently).
>
> [1]
>
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?h=v5.13&id=ff1395609e20c1cd98b3ec65d16dc18f0471dca3
>
> Regards,
> CK
>
> > return 0;
> > }
> >
>
>
\
 
 \ /
  Last update: 2021-07-10 09:09    [W:0.020 / U:0.232 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site