Messages in this thread |  | | From | Hongwei Zhang <> | Subject | [PATCH v1 1/1] mtd: spi-nor: Add some M45PEx ids | Date | Thu, 1 Jul 2021 11:18:39 -0400 |
| |
Hi Michael,
Ok, I will separately resubmit a revised patch with update later.
Regards, --Hongwei
>Subject: [EXTERNAL] Re: [PATCH v1 1/1] mtd: spi-nor: Add some M45PEx ids > >>> Am 2021-06-29 17:08, schrieb Hongwei Zhang: >>>> Add some Micron M45PEx flash memeories into the IDs table. >>> >>> Did you test all these flashes? >>> >> No, the patch was added in porting drivers related to AST2600 EVB. > >Please note, that all flashes which are added must be tested. > >>>> Fixes: dd1e9367157f900616f (ARM: dts: everest: Add phase corrections >>>> for >>>> eMMC) >>> >>> Bogus Fixes tag. First, I cannot find this commit id, which tree is >>> that? Secondly, adding new flash ids don't fix anything, esp not >>> something related to eMMC. >>> >> Sorry for the confusion, I thought Fixes tag could be also used for >> referencing the revision base for the patch to aplly on. >> I used dev-5.10 branch from >> https://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgith >> >ub.com%2Fopenbmc%2Flinux.git&data=04%7C01%7Chongweiz%40ami.com%7C72a7d2569f6a4cb >629fe08d93c775f8a%7C27e97857e15f486cb58e86c2b3040f93%7C1%7C0%7C637607305682606148%7 >CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0 >%3D%7C1000&sdata=h%2BoFfg9m0udXdQgb85oq0NKEIcL1DFNha186lP0HwG8%3D&reserve >d=0 , should I use a different repository? > >AFAIK commits in fixes tags must be relative to Linus Torvalds' tree (or a subtree must not rebase, like >the networking trees, which means they will end up in Torvalds' tree). > >Anyway, this is not a fix and therefore there must be no Fixes: tag. > >-michael
|  |