lkml.org 
[lkml]   [2021]   [Jun]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v2] kfence: skip DMA allocations
On Tue, 29 Jun 2021 at 18:17, Alexander Potapenko <glider@google.com> wrote:
> Allocation requests with __GFP_DMA/__GFP_DMA32 or
> SLAB_CACHE_DMA/SLAB_CACHE_DMA32 cannot be fulfilled by KFENCE, because
> they must reside in low memory, whereas KFENCE memory pool is located in
> high memory.
>
> Skip such allocations to avoid crashes where DMAable memory is expected.
>
> Fixes: 0ce20dd84089 ("mm: add Kernel Electric-Fence infrastructure")
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: Dmitry Vyukov <dvyukov@google.com>
> Cc: Marco Elver <elver@google.com>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: stable@vger.kernel.org # 5.12+
> Signed-off-by: Alexander Potapenko <glider@google.com>

Reviewed-by: Marco Elver <elver@google.com>

Thanks!


> ---
>
> v2:
> - added parentheses around the GFP clause, as requested by Marco
> ---
> mm/kfence/core.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/mm/kfence/core.c b/mm/kfence/core.c
> index 4d21ac44d5d35..f7ce3d876bc9e 100644
> --- a/mm/kfence/core.c
> +++ b/mm/kfence/core.c
> @@ -760,6 +760,14 @@ void *__kfence_alloc(struct kmem_cache *s, size_t size, gfp_t flags)
> if (size > PAGE_SIZE)
> return NULL;
>
> + /*
> + * Skip DMA allocations. These must reside in the low memory, which we
> + * cannot guarantee.
> + */
> + if ((flags & (__GFP_DMA | __GFP_DMA32)) ||
> + (s->flags & (SLAB_CACHE_DMA | SLAB_CACHE_DMA32)))
> + return NULL;
> +
> return kfence_guarded_alloc(s, size, flags);
> }
>
> --
> 2.32.0.93.g670b81a890-goog
>

\
 
 \ /
  Last update: 2021-06-29 18:42    [W:0.792 / U:0.296 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site