lkml.org 
[lkml]   [2021]   [Jun]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] fs: btrfs: extent_map: removed unneeded variable
Date
On 29/06/2021 10:51, lijian_8010a29@163.com wrote:
> From: lijian <lijian@yulong.com>
>
> removed unneeded variable 'ret'.

Wouldn't it make more sense to return an error (-ENOENT??) in case
the em lookup fails and handle the error in btrfs_finish_ordered_io()
as this is the only caller of unpin_extent_cache()?

I've actually tripped over this a couple of times already when
investigating extent map and ordered extent splitting problems
on zoned filesystems:

em = lookup_extent_mapping(tree, start, len);
WARN_ON(!em || em->start != start);

Maybe even turn this WARN_ON() into an ASSERT() when introducing proper
error handling, as we shouldn't really get there unless we have a logical
error.

\
 
 \ /
  Last update: 2021-06-29 11:04    [W:0.068 / U:0.180 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site