[lkml]   [2021]   [Jun]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
Patch in this message
Subject[RFC] fpga: dfl: fme: Fix cpu hotplug code
Commit 724142f8c42a ("fpga: dfl: fme: add performance
reporting support") added performance reporting support
for FPGA management engine via perf.

It also added cpu hotplug feature but it didn't add
pmu migration call in cpu offline function.
This can create an issue incase the current designated
cpu being used to collect fme pmu data got offline,
as based on current code we are not migrating fme pmu to
new target cpu. Because of that perf will still try to
fetch data from that offline cpu and hence we will not
get counter data.

Patch fixed this issue by adding pmu_migrate_context call
in fme_perf_offline_cpu function.

Fixes: 724142f8c42a ("fpga: dfl: fme: add performance reporting support")
Signed-off-by: Kajol Jain <>
drivers/fpga/dfl-fme-perf.c | 4 ++++
1 file changed, 4 insertions(+)

- This fix patch is not tested (as I don't have required environment).
But issue mentioned in the commit msg can be re-created, by starting any
fme_perf event and while its still running, offline current designated
cpu pointed by cpumask file. Since current code didn't migrating pmu,
perf gonna try getting counts from that offlined cpu and hence we will
not get event data.
diff --git a/drivers/fpga/dfl-fme-perf.c b/drivers/fpga/dfl-fme-perf.c
index 4299145ef347..b9a54583e505 100644
--- a/drivers/fpga/dfl-fme-perf.c
+++ b/drivers/fpga/dfl-fme-perf.c
@@ -953,6 +953,10 @@ static int fme_perf_offline_cpu(unsigned int cpu, struct hlist_node *node)
return 0;

priv->cpu = target;
+ /* Migrate fme_perf pmu events to the new target cpu */
+ perf_pmu_migrate_context(&priv->pmu, cpu, target);
return 0;

 \ /
  Last update: 2021-06-28 09:19    [W:0.060 / U:2.608 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site