lkml.org 
[lkml]   [2021]   [Mar]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 7/7] media: uapi: move VP8 stateless controls out of staging
From
Date
Hi Ezequiel,

This series looks very good. There is just one define that needs a V4L2_ prefix:

On 02/03/2021 21:54, Ezequiel Garcia wrote:
> Until now, the VP8 V4L2 API was not exported as a public API,
> and only defined in a private media header (media/vp8-ctrls.h).
>
> The reason for this was a concern about the API not complete
> and ready to support VP8 decoding hardware accelerators.
>
> After reviewing the VP8 specification in detail, and now
> that the API is able to support Cedrus and Hantro G1,
> we can consider this ready.
>
> Signed-off-by: Ezequiel Garcia <ezequiel@collabora.com>

<snip>

> diff --git a/include/uapi/linux/v4l2-controls.h b/include/uapi/linux/v4l2-controls.h

<snip>

> +#define VP8_FRAME_IS_KEY_FRAME(hdr) \
> + (!!((hdr)->flags & V4L2_VP8_FRAME_FLAG_KEY_FRAME))

It's used in several drivers, so it is probably best to add a separate
patch before this patch to rename it.

Everything else looks fine, so I expect to make a PR once I have a v2 that
fixes this.

Regards,

Hans

\
 
 \ /
  Last update: 2021-03-03 19:10    [W:0.108 / U:0.260 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site