lkml.org 
[lkml]   [2021]   [Mar]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] treewide: remove editor modelines and cruft
Hi Masahiro,

On Wed, Mar 24, 2021 at 10:57 AM Masahiro Yamada <masahiroy@kernel.org> wrote:
>
> The section "19) Editor modelines and other cruft" in
> Documentation/process/coding-style.rst clearly says,
> "Do not include any of these in source files."
>
> I recently receive a patch to explicitly add a new one.
>
> Let's do treewide cleanups, otherwise some people follow the existing
> code and attempt to upstream their favoriate editor setups.
>
> It is even nicer if scripts/checkpatch.pl can check it.
>
> If we like to impose coding style in an editor-independent manner,
> I think editorconfig (patch [1]) is a saner solution.
>
> [1] https://lore.kernel.org/lkml/20200703073143.423557-1-danny@kdrag0n.dev/
>
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>

+1 It is great to get rid of those.

For auxdisplay:

Reviewed-by: Miguel Ojeda <ojeda@kernel.org>

For the rest, I did a quick visual inspection and didn't see anything wrong.

Cheers,
Miguel

\
 
 \ /
  Last update: 2021-03-24 12:02    [W:0.063 / U:1.728 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site