lkml.org 
[lkml]   [2021]   [Mar]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v3 3/8] extconn: Clean-up few drivers by using managed work init
From
Date
Hello Chanwoo, Greg,

Thanks for the review.

On Wed, 2021-03-24 at 11:09 +0900, Chanwoo Choi wrote:
> Hi,
>
> Need to fix the work as following:
> s/extconn/extcon
>
> And I'd like you to use the more correct patch title like the
> following example:
> "extcon: Use resource-managed function for delayed work"

I think Greg merged this already. How should we handle this?

> @@ -112,7 +113,9 @@ static int gpio_extcon_probe(struct
> > platform_device *pdev)
> > if (ret < 0)
> > return ret;
> >
> > - INIT_DELAYED_WORK(&data->work, gpio_extcon_work);
> > + ret = devm_delayed_work_autocancel(dev, &data->work,
> > gpio_extcon_work);
> > + if (ret)
> > + return ret;
>
> Need to add the error log as following:
> if (ret) {
> dev_err(dev, "Failed to initialize delayed_work");
> return ret;
> }

I could send incremental patch to Greg for this but it does not change
the commit message.

Best Regards
Matti Vaittinen


\
 
 \ /
  Last update: 2021-03-24 06:04    [W:0.113 / U:1.296 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site