lkml.org 
[lkml]   [2021]   [Mar]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v1 1/5] mfd: intel_quark_i2c_gpio: revert "Constify static struct resources"
On Tue, Mar 23, 2021 at 09:14:53AM +0000, Lee Jones wrote:
> On Tue, 02 Mar 2021, Andy Shevchenko wrote:
>
> > The structures are used as place holders, so they are modified at run-time.
> > Obviously they may not be constants.
> >
> > BUG: unable to handle page fault for address: d0643220
> > ...
> > CPU: 0 PID: 110 Comm: modprobe Not tainted 5.11.0+ #1
> > Hardware name: Intel Corp. QUARK/GalileoGen2, BIOS 0x01000200 01/01/2014
> > EIP: intel_quark_mfd_probe+0x93/0x1c0 [intel_quark_i2c_gpio]
> >
> > This partially reverts the commit c4a164f41554d2899bed94bdcc499263f41787b4.
> >
> > While at it, add a comment to avoid similar changes in the future.
> >
> > Fixes: c4a164f41554 ("mfd: Constify static struct resources")
> > Cc: Rikard Falkeborn <rikard.falkeborn@gmail.com>
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > ---
> > drivers/mfd/intel_quark_i2c_gpio.c | 6 ++++--
> > 1 file changed, 4 insertions(+), 2 deletions(-)
>
> Applied to -fixes for testing, thanks.

Thanks!

--
With Best Regards,
Andy Shevchenko


\
 
 \ /
  Last update: 2021-03-23 11:32    [W:0.190 / U:4.856 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site