lkml.org 
[lkml]   [2021]   [Mar]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v13 3/5] dt-bindings: leds: Add LED_FUNCTION_MOONLIGHT definitions
Pavel Machek <pavel@ucw.cz> 於 2021年2月19日 週五 下午6:47寫道:
>
> Hi!
>
> > From: Gene Chen <gene_chen@richtek.com>
> >
> > Add LED_FUNCTION_MOONLIGHT definitions
> >
> > Signed-off-by: Gene Chen <gene_chen@richtek.com>
> > Acked-by: Jacek Anaszewski <jacek.anaszewski@gmail.com>
> > Acked-by: Rob Herring <robh@kernel.org>
>
> No, sorry, I don't believe we need another define for flash/torch.
>

As previous discuss,
> We use term "Moonlight" as reference says
> "When you are trying to imitate moonlight you need to use low voltage,
> softer lighting. You don’t want something that’s too bright"
> which is focus on brightness instead of color.

If any concern about this change, maybe we use LED_FUNCTION_INDICATOR instead?
(refs: https://lkml.org/lkml/2020/11/24/1267)


> Best regards,
> Pavel
> --
> http://www.livejournal.com/~pavelmachek

\
 
 \ /
  Last update: 2021-03-02 16:10    [W:0.115 / U:1.524 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site