lkml.org 
[lkml]   [2021]   [Feb]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH for-next 25/32] scsi: pcmcia: Replace spin_lock_irqsave with spin_lock in hard IRQ
Date
It is redundant to do irqsave and irqrestore in hardIRQ context, where
it has been in a irq-disabled context.

Signed-off-by: Xiaofei Tan <tanxiaofei@huawei.com>
---
drivers/scsi/pcmcia/sym53c500_cs.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/scsi/pcmcia/sym53c500_cs.c b/drivers/scsi/pcmcia/sym53c500_cs.c
index a366ff1..67719de 100644
--- a/drivers/scsi/pcmcia/sym53c500_cs.c
+++ b/drivers/scsi/pcmcia/sym53c500_cs.c
@@ -341,7 +341,6 @@ SYM53C500_pio_write(int fast_pio, int base, unsigned char *request, unsigned int
static irqreturn_t
SYM53C500_intr(int irq, void *dev_id)
{
- unsigned long flags;
struct Scsi_Host *dev = dev_id;
DEB(unsigned char fifo_size;)
DEB(unsigned char seq_reg;)
@@ -353,7 +352,7 @@ SYM53C500_intr(int irq, void *dev_id)
struct scsi_cmnd *curSC = data->current_SC;
int fast_pio = data->fast_pio;

- spin_lock_irqsave(dev->host_lock, flags);
+ spin_lock(dev->host_lock);

VDEB(printk("SYM53C500_intr called\n"));

@@ -487,7 +486,7 @@ SYM53C500_intr(int irq, void *dev_id)
break;
}
out:
- spin_unlock_irqrestore(dev->host_lock, flags);
+ spin_unlock(dev->host_lock);
return IRQ_HANDLED;

idle_out:
--
2.8.1
\
 
 \ /
  Last update: 2021-02-07 12:51    [W:0.156 / U:28.932 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site