lkml.org 
[lkml]   [2021]   [Feb]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH for-next 01/32] scsi: 53c700: Replace spin_lock_irqsave with spin_lock in hard IRQ
Date
It is redundant to do irqsave and irqrestore in hardIRQ context, where
it has been in a irq-disabled context.

Signed-off-by: Xiaofei Tan <tanxiaofei@huawei.com>
---
drivers/scsi/53c700.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/scsi/53c700.c b/drivers/scsi/53c700.c
index 3242ff6..6c2ef46 100644
--- a/drivers/scsi/53c700.c
+++ b/drivers/scsi/53c700.c
@@ -1491,7 +1491,6 @@ NCR_700_intr(int irq, void *dev_id)
__u8 istat;
__u32 resume_offset = 0;
__u8 pun = 0xff, lun = 0xff;
- unsigned long flags;
int handled = 0;

/* Use the host lock to serialise access to the 53c700
@@ -1499,7 +1498,7 @@ NCR_700_intr(int irq, void *dev_id)
* lock to enter the done routines. When that happens, we
* need to ensure that for this driver, the host lock and the
* queue lock point to the same thing. */
- spin_lock_irqsave(host->host_lock, flags);
+ spin_lock(host->host_lock);
if((istat = NCR_700_readb(host, ISTAT_REG))
& (SCSI_INT_PENDING | DMA_INT_PENDING)) {
__u32 dsps;
@@ -1748,7 +1747,7 @@ NCR_700_intr(int irq, void *dev_id)
}
}
out_unlock:
- spin_unlock_irqrestore(host->host_lock, flags);
+ spin_unlock(host->host_lock);
return IRQ_RETVAL(handled);
}

--
2.8.1
\
 
 \ /
  Last update: 2021-02-07 12:47    [W:0.142 / U:0.980 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site