lkml.org 
[lkml]   [2021]   [Feb]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v3] kdb: kdb_support: Fix debugging information problem
Hi,

On Wed, Feb 3, 2021 at 3:31 AM Stephen Zhang <stephenzhangzsd@gmail.com> wrote:
>
> Doug Anderson <dianders@chromium.org> 于2021年2月3日周三 上午1:40写道:
>>
>> <tab>kdb_dbg_printf(AR, "returns [...] (%s)\n",
>> <tab><tab> ret, symtab->sym_start, [...], symtab->sym_name);
>
>
> Thank you for the detailed explanation. In this case, Shouldn't the "ret" be under
> the "(AR"? like below:
>
> <tab>kdb_dbg_printf(AR, "returns [...] (%s)\n",
> <tab><tab> ret, symtab->sym_start, [...], symtab->sym_name);
>
> See
> <https://www.kernel.org/doc/html/v5.10/process/coding-style.html#breaking-long-lines-and-strings>
> where it says "A very commonly used style is to align descendants to a function open parenthesis".
> The "descendants" here means the next line, right?

Yes, "descendants" means the next line.

I have a guess about what your problem is. In kernel land, tabs are 8
spaces, not 4. Also make sure your editor is using a fixed-width
font. In gmail my example might not look like it's lining up, but
when you go into the editor it should.

-Doug

\
 
 \ /
  Last update: 2021-02-03 17:02    [W:0.127 / U:0.536 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site