lkml.org 
[lkml]   [2021]   [Feb]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v1 01/12] gna: add driver module
On Fri, Feb 26, 2021 at 07:29:39PM +0100, Maciej Kwapulinski wrote:
>
> Andy Shevchenko <andy.shevchenko@gmail.com> writes:
>
> > On Tue, Feb 16, 2021 at 6:11 PM Maciej Kwapulinski
> > <maciej.kwapulinski@linux.intel.com> wrote:
> >>
> ....
> >> +#define GNA_DRV_VER "1.2.0"
> >
> > Nowadays the version is the Git SHA sum.
> >
>
> right, "version" is present in about 7% of all modules

And it should be removed from them.

> do You mean version should be skipped over (automatically generated)
> srcversion field? or maybe You suggest any (better) technique?

Drop it entirely from the driver code, it means nothing when the driver
is merged into the kernel tree.

thanks,

greg k-h

\
 
 \ /
  Last update: 2021-02-27 07:34    [W:0.177 / U:0.140 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site