lkml.org 
[lkml]   [2021]   [Feb]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] staging: wimax/i2400m: fix byte-order type issue
On Sat, Feb 20, 2021 at 06:22:31PM +0530, karthik alapati wrote:
> fix sparse type warning by converting le32 types to
> host byte-order types before comparison
>
> Signed-off-by: karthik alapati <mail@karthek.com>
> ---
> drivers/staging/wimax/i2400m/fw.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/wimax/i2400m/fw.c b/drivers/staging/wimax/i2400m/fw.c
> index 92ea5c101..f09de1810 100644
> --- a/drivers/staging/wimax/i2400m/fw.c
> +++ b/drivers/staging/wimax/i2400m/fw.c
> @@ -511,7 +511,7 @@ ssize_t __i2400m_bm_ack_verify(struct i2400m *i2400m, int opcode,
> opcode, i2400m_brh_get_response(ack));
> goto error_ack_failed;
> }
> - if (ack_size < ack->data_size + sizeof(*ack)) {
> + if (ack_size < le32_to_cpu(ack->data_size) + sizeof(*ack)) {
> dev_err(dev, "boot-mode cmd %d: SW BUG "
> "driver provided only %zu bytes for %zu bytes "
> "of data\n", opcode, ack_size,

You sent 3 patches that seem to do the same thing, yet are a bit
different?

Please make your patches a patch series and provide proper subject lines
to make them unique. I have now dropped all of your submitted patches
from my review queue.

thanks,

greg k-h

\
 
 \ /
  Last update: 2021-02-21 12:28    [W:0.038 / U:2.776 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site