lkml.org 
[lkml]   [2021]   [Feb]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v2 1/3] kconfig: Remove duplicate call to sym_get_string_value()
On Tue, Feb 16, 2021 at 3:15 AM Mickaël Salaün <mic@digikod.net> wrote:
>
> From: Mickaël Salaün <mic@linux.microsoft.com>
>
> Use the saved returned value of sym_get_string_value() instead of
> calling it twice.
>
> Cc: Masahiro Yamada <masahiroy@kernel.org>
> Signed-off-by: Mickaël Salaün <mic@linux.microsoft.com>
> Link: https://lore.kernel.org/r/20210215181511.2840674-2-mic@digikod.net
> ---


Applied to linux-kbuild. Thanks.



> scripts/kconfig/conf.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/kconfig/conf.c b/scripts/kconfig/conf.c
> index db03e2f45de4..18a233d27a8d 100644
> --- a/scripts/kconfig/conf.c
> +++ b/scripts/kconfig/conf.c
> @@ -137,7 +137,7 @@ static int conf_string(struct menu *menu)
> printf("%*s%s ", indent - 1, "", menu->prompt->text);
> printf("(%s) ", sym->name);
> def = sym_get_string_value(sym);
> - if (sym_get_string_value(sym))
> + if (def)
> printf("[%s] ", def);
> if (!conf_askvalue(sym, def))
> return 0;
> --
> 2.30.0
>


--
Best Regards
Masahiro Yamada

\
 
 \ /
  Last update: 2021-02-21 09:56    [W:0.071 / U:5.008 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site