lkml.org 
[lkml]   [2021]   [Feb]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH net-next v2] misc: Add Renesas Synchronization Management Unit (SMU) support
On Fri, Feb 12, 2021 at 07:06:17PM +0000, Min Li wrote:
> >
> > On Fri, Feb 12, 2021 at 03:44:52PM +0000, Min Li wrote:
> > > > >
> > > > > -set combomode
> > > > > -get dpll's state
> > > > > -get dpll's ffo
> > > > >
> > > > > This driver must work with Renesas MFD driver to access SMU
> > > > > through I2C/SPI.
> > > > >
> > > > > Changes since v1:
> > > > > -Provide more background for purpose of the change.
> > > > > -Provide compat_ioctl support
> > > > > -Fix ioctl cmd definition
> > > >
> > > > This "changes" list goes below the --- line.
> > > >
> > >
> > > Sorry, is this a problem that you are requesting me to address? I am bit
> > confused...
> >
> > Yes, please place that list of changes below the --- line in your patch.
> > The documentation says to do this, right?
> >
> Hi Greg
>
> Do you mean this "---" like below? How can I do that? Sorry I was never asked to do that from other reviewer.

Yes, that line.

The documentation should tell you how to do that, as per my patch bot:

- This looks like a new version of a previously submitted patch, but you
did not list below the --- line any changes from the previous version.
Please read the section entitled "The canonical patch format" in the
kernel file, Documentation/SubmittingPatches for what needs to be done
here to properly describe this.

thanks,

greg k-h

\
 
 \ /
  Last update: 2021-02-13 09:30    [W:0.115 / U:4.860 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site