lkml.org 
[lkml]   [2021]   [Feb]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH net-next 1/8] dt-bindings: net: dsa: dt bindings for microchip lan937x
> > > +        ethernet-ports {
> > > + #address-cells = <1>;
> > > + #size-cells = <0>;
> > > + port@0 {
> > > + reg = <0>;
> > > + label = "lan1";
> > > + };
> > > + port@1 {
> > > + reg = <1>;
> > > + label = "lan2";
> > > + };
> > > + port@2 {
> > > + reg = <7>;
> >
> > reg should match node index (port@2), here and everywhere below. As
> > for
> > the net device labels, I'm not sure if the mismatch is deliberate
> > there.
> reg & port node indexes are different here because to match with the
> physical to logical port mapping done in the LAN9374. I realized that
> the description is missing and that is to be added. However, should reg
> & port node index match for the net dev?
> If it should be the same, then the same can be acheived by renaming a
> label (lanx) as well.

The label should match whatever the text on the device case says. So
it is fine if port 2 says lan3 on the front panel. However, port@2
should have reg=<2>. Please change it to port@7. This is a generic DT
requirement, not specific to DSA.

Andrew

\
 
 \ /
  Last update: 2021-02-10 20:03    [W:0.287 / U:0.792 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site