lkml.org 
[lkml]   [2021]   [Dec]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v5 15/24] ARM: tegra: Add usb-role-switch property to USB OTG ports
    Date
    From: Stefan Eichenberger <stefan.eichenberger@toradex.com>

    If an USB port is an OTG port, then we should add the usb-role-switch
    property. Otherwise XUSB setup fails and therefore padctl is unable to
    set up the ports. This leads to broken USB and PCIe ports. Add the
    usb-role-switch properties to Tegra124 device-trees to fix the problem.

    The error message shown without this patch is e.g:
    usb2-0: usb-role-switch not found for otg mode

    [digetx@gmail.com: improved commit message]
    Tested-by: Thomas Graichen <thomas.graichen@gmail.com> # T124 Nyan Big
    Signed-off-by: Stefan Eichenberger <stefan.eichenberger@toradex.com>
    Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
    ---
    arch/arm/boot/dts/tegra124-apalis-v1.2.dtsi | 1 +
    arch/arm/boot/dts/tegra124-apalis.dtsi | 1 +
    arch/arm/boot/dts/tegra124-nyan.dtsi | 1 +
    arch/arm/boot/dts/tegra124-venice2.dts | 2 +-
    4 files changed, 4 insertions(+), 1 deletion(-)

    diff --git a/arch/arm/boot/dts/tegra124-apalis-v1.2.dtsi b/arch/arm/boot/dts/tegra124-apalis-v1.2.dtsi
    index cde9ae8fa04b..b9198f842a34 100644
    --- a/arch/arm/boot/dts/tegra124-apalis-v1.2.dtsi
    +++ b/arch/arm/boot/dts/tegra124-apalis-v1.2.dtsi
    @@ -1885,6 +1885,7 @@ ports {
    usb2-0 {
    status = "okay";
    mode = "otg";
    + usb-role-switch;
    vbus-supply = <&reg_usbo1_vbus>;
    };

    diff --git a/arch/arm/boot/dts/tegra124-apalis.dtsi b/arch/arm/boot/dts/tegra124-apalis.dtsi
    index a46d9ba9bb7a..1a996fb78ee2 100644
    --- a/arch/arm/boot/dts/tegra124-apalis.dtsi
    +++ b/arch/arm/boot/dts/tegra124-apalis.dtsi
    @@ -1877,6 +1877,7 @@ ports {
    usb2-0 {
    status = "okay";
    mode = "otg";
    + usb-role-switch;
    vbus-supply = <&reg_usbo1_vbus>;
    };

    diff --git a/arch/arm/boot/dts/tegra124-nyan.dtsi b/arch/arm/boot/dts/tegra124-nyan.dtsi
    index 63a81270300a..93a40a84b792 100644
    --- a/arch/arm/boot/dts/tegra124-nyan.dtsi
    +++ b/arch/arm/boot/dts/tegra124-nyan.dtsi
    @@ -466,6 +466,7 @@ usb2-0 {
    vbus-supply = <&vdd_usb1_vbus>;
    status = "okay";
    mode = "otg";
    + usb-role-switch;
    };

    usb2-1 {
    diff --git a/arch/arm/boot/dts/tegra124-venice2.dts b/arch/arm/boot/dts/tegra124-venice2.dts
    index e6b54ac1ebd1..de8c18e6b7e6 100644
    --- a/arch/arm/boot/dts/tegra124-venice2.dts
    +++ b/arch/arm/boot/dts/tegra124-venice2.dts
    @@ -972,7 +972,7 @@ ports {
    usb2-0 {
    status = "okay";
    mode = "otg";
    -
    + usb-role-switch;
    vbus-supply = <&vdd_usb1_vbus>;
    };

    --
    2.33.1
    \
     
     \ /
      Last update: 2021-12-08 18:39    [W:3.696 / U:0.036 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site