lkml.org 
[lkml]   [2021]   [Dec]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH V8 03/14] rtla: Add osnoise tool
On Thu, 2 Dec 2021 16:18:53 +0100
Daniel Bristot de Oliveira <bristot@kernel.org> wrote:

> >> + if (!strcmp(context->orig_cpus, context->curr_cpus))
> >> + goto out_done;
> >> +
> >> + retval = write(context->cpus_fd, context->orig_cpus, strlen(context->orig_cpus));
> >
> > 'strlen(context->orig_cpus) + 1' for write size;
> >
> >> + if (retval < strlen(context->orig_cpus))
> >
> > Same here. Check 'strlen(context->orig_cpus) + 1'
>
> Fixed in v9.

And if you used the tracefs_instance_file_write() function, you would not
have had his bug ;-)

-- Steve

\
 
 \ /
  Last update: 2021-12-08 23:14    [W:0.057 / U:0.704 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site