lkml.org 
[lkml]   [2021]   [Dec]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [PATCH] intel_th: remove redundant re-assignment of pointer hubdrv
On Sat, Dec 04, 2021 at 11:39:34PM +0000, Colin Ian King wrote:
> The pointer hubdrv is being re-assigned the same value as it was
> initialized with only a few lines earlier. The re-assignment is
> redundant and can be removed.
>
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
> ---
> drivers/hwtracing/intel_th/core.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/hwtracing/intel_th/core.c b/drivers/hwtracing/intel_th/core.c
> index 7e753a75d23b..5de47b89a9e1 100644
> --- a/drivers/hwtracing/intel_th/core.c
> +++ b/drivers/hwtracing/intel_th/core.c
> @@ -1048,7 +1048,6 @@ int intel_th_set_output(struct intel_th_device *thdev,
> * hub is instantiated together with the source device that
> * calls here, so guaranteed to be present.
> */
> - hubdrv = to_intel_th_driver(hub->dev.driver);
> if (!hubdrv || !try_module_get(hubdrv->driver.owner))
^^^^^^^
This NULL check doesn't make sense. "hubdrv" is "hub - some_offset"
where "some_offset" is zero. We've already dereferenced "hub" so
"hubdrv" can't be NULL.

regards,
dan carpenter

\
 
 \ /
  Last update: 2021-12-07 13:19    [W:0.038 / U:1.488 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site