lkml.org 
[lkml]   [2021]   [Dec]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] staging: vt6655: refactor byMinChannel to min_channel
From
On 12/4/21 12:09, Alberto Merciai wrote:
> On Sat, Dec 04, 2021 at 11:27:43AM +0300, Pavel Skripkin wrote:
>> Looks like this variable is set, but never used. Shouldn't it be just
>> removed?
>>
>> Same for max_channel (or byMaxChannel).
>
> To be honest, I would prefer leave them where they are. I'm only
> refactoring the code considering less the logic aspect.
>
> I don't know if these variables will become usefull in a second
> moment.
>
> Anyway, If you consider that this could be a good moment to remove
> them we can proceed.
>
> What do you think about that?
>

I think, it should be up to maintainers to decide, but them can be
removed now and if somebody will need them later, he can bring them back
without any pain. For now it's just useless memory usage.


I skimmed through priv fields usage and looks like many of them are just
set, but never used. I guess, some kind of evolution removed all uses of
them...




With regards,
Pavel Skripkin

\
 
 \ /
  Last update: 2021-12-04 10:23    [W:0.046 / U:0.596 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site