lkml.org 
[lkml]   [2021]   [Dec]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] staging: vt6655: refactor byMinChannel to min_channel
From
On 12/4/21 03:40, Alberto Merciai wrote:
> Replace camelcase hungarian notated variable "byMinChannel"
> into linux kernel coding style equivalent variable "min_channel".
>
> Signed-off-by: Alberto Merciai <alb3rt0.m3rciai@gmail.com>
> ---
> drivers/staging/vt6655/device.h | 2 +-
> drivers/staging/vt6655/device_main.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/vt6655/device.h b/drivers/staging/vt6655/device.h
> index 6ea4165e4929..109d20a010ab 100644
> --- a/drivers/staging/vt6655/device.h
> +++ b/drivers/staging/vt6655/device.h
> @@ -200,7 +200,7 @@ struct vnt_private {
> unsigned char byTopOFDMBasicRate;
> unsigned char byTopCCKBasicRate;
>
> - unsigned char byMinChannel;
> + unsigned char min_channel;
> unsigned char max_channel;
>
> unsigned char preamble_type;
> diff --git a/drivers/staging/vt6655/device_main.c b/drivers/staging/vt6655/device_main.c
> index 313f0241d989..4d92b5df5312 100644
> --- a/drivers/staging/vt6655/device_main.c
> +++ b/drivers/staging/vt6655/device_main.c
> @@ -228,7 +228,7 @@ static void device_init_registers(struct vnt_private *priv)
> spin_unlock_irqrestore(&priv->lock, flags);
>
> /* Get Channel range */
> - priv->byMinChannel = 1;
> + priv->min_channel = 1;
> priv->max_channel = CB_MAX_CHANNEL;
>
> /* Get Antena */
>

Looks like this variable is set, but never used. Shouldn't it be just
removed?

Same for max_channel (or byMaxChannel).




With regards,
Pavel Skripkin

\
 
 \ /
  Last update: 2021-12-04 09:28    [W:0.074 / U:2.552 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site