lkml.org 
[lkml]   [2021]   [Dec]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] media: staging: max96712: add V4L2 dependencies
Hi Arnd,

Thanks for your patch.

I'm sorry for introducing the fault in the first place, Sakari already
sent a fix for my mistake [1]. Just waiting for Mauro to pick it up.

1. https://patchwork.linuxtv.org/project/linux-media/patch/20211126080623.1587610-1-sakari.ailus@linux.intel.com/

On 2021-12-04 18:45:48 +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> Without the extra dependencies, I run into randconfig build failures:
>
> WARNING: unmet direct dependencies detected for VIDEO_V4L2_SUBDEV_API
> Depends on [n]: MEDIA_SUPPORT [=y] && VIDEO_DEV [=n] && MEDIA_CONTROLLER [=y]
> Selected by [y]:
> - VIDEO_MAX96712 [=y] && STAGING [=y] && STAGING_MEDIA [=y] && MEDIA_SUPPORT [=y] && I2C [=y] && OF_GPIO [=y]
>
> aarch64-linux-ld: drivers/staging/media/max96712/max96712.o: in function `max96712_probe':
> max96712.c:(.text+0x1b8): undefined reference to `v4l2_fwnode_endpoint_parse'
> aarch64-linux-ld: max96712.c:(.text+0x374): undefined reference to `v4l2_ctrl_handler_init_class'
> aarch64-linux-ld: max96712.c:(.text+0x3b0): undefined reference to `v4l2_ctrl_new_std'
>
> Fixes: 5814f32fef13 ("media: staging: max96712: Add basic support for MAX96712 GMSL2 deserializer")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/staging/media/max96712/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/staging/media/max96712/Kconfig b/drivers/staging/media/max96712/Kconfig
> index 258d47644cbd..62534110ca3b 100644
> --- a/drivers/staging/media/max96712/Kconfig
> +++ b/drivers/staging/media/max96712/Kconfig
> @@ -3,6 +3,7 @@ config VIDEO_MAX96712
> tristate "Maxim MAX96712 Quad GMSL2 Deserializer support"
> depends on I2C
> depends on OF_GPIO
> + depends on VIDEO_DEV && VIDEO_V4L2
> select V4L2_FWNODE
> select VIDEO_V4L2_SUBDEV_API
> select MEDIA_CONTROLLER
> --
> 2.29.2
>

--
Kind Regards,
Niklas Söderlund

\
 
 \ /
  Last update: 2021-12-04 21:57    [W:0.026 / U:26.724 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site