lkml.org 
[lkml]   [2021]   [Dec]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH v3 22/22] kvm: x86: Disable interception for IA32_XFD on demand
Date
> From: Tian, Kevin
> Sent: Wednesday, December 29, 2021 11:35 AM
> >
> > Speaking of nested, interception of #NM in
> vmx_update_exception_bitmap()
> > is wrong
> > with respect to nested guests. Until XFD is supported for L2, which I didn't
> > see
> > in this series, #NM should not be intercepted while L2 is running.
>
> Can you remind what additional thing is required to support XFD for L2?

ok, at least we require additional work on when to disable write interception.
It can be done only when both L0 and L1 make the same decision, just like
what we did for many other VMCS settings...

> If only about performance I prefer to the current conservative approach
> as the first step. As explained earlier, #NM should be rare if the guest
> doesn't run AMX applications at all. Adding nested into this picture doesn't
> make things a lot worser.

All your comments incorporated except this one. As said always trapping
#NM for L2 is not a big problem, as long as it's rare and don't break function.
Usually a relatively static scheme is safer than a dynamic one in case of
anything overlooked for the initial implementation. 😊

Thanks
Kevin
\
 
 \ /
  Last update: 2021-12-29 08:19    [W:0.122 / U:0.252 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site