lkml.org 
[lkml]   [2021]   [Dec]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v2 02/23] counter: ftm-quaddec: Drop unused platform_set_drvdata()
    On Mon, Dec 27, 2021 at 10:45:05AM +0100, Uwe Kleine-König wrote:
    > The driver doesn't ever use platform_get_drvdata, so drop this unused
    > call.
    >
    > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>

    Acked-by: William Breathitt Gray <vilhelm.gray@gmail.com>

    By the way, it should be possible to remove pdev from struct ftm_quaddec
    because &ftm->pdev->dev is stored to ftm->counter.parent and can be
    accessed from there if needed.

    > ---
    > drivers/counter/ftm-quaddec.c | 2 --
    > 1 file changed, 2 deletions(-)
    >
    > diff --git a/drivers/counter/ftm-quaddec.c b/drivers/counter/ftm-quaddec.c
    > index 5ef0478709cd..9272f7b58beb 100644
    > --- a/drivers/counter/ftm-quaddec.c
    > +++ b/drivers/counter/ftm-quaddec.c
    > @@ -269,8 +269,6 @@ static int ftm_quaddec_probe(struct platform_device *pdev)
    > if (!ftm)
    > return -ENOMEM;
    >
    > - platform_set_drvdata(pdev, ftm);
    > -
    > io = platform_get_resource(pdev, IORESOURCE_MEM, 0);
    > if (!io) {
    > dev_err(&pdev->dev, "Failed to get memory region\n");
    > --
    > 2.33.0
    >
    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2021-12-29 07:43    [W:27.499 / U:0.164 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site