lkml.org 
[lkml]   [2021]   [Dec]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 04/13] media: s5p-mfc: Use platform_get_irq() to get the interrupt
From

On 23.12.2021 18:30, Lad Prabhakar wrote:
> platform_get_resource(pdev, IORESOURCE_IRQ, ..) relies on static
> allocation of IRQ resources in DT core code, this causes an issue
> when using hierarchical interrupt domains using "interrupts" property
> in the node as this bypasses the hierarchical setup and messes up the
> irq chaining.
>
> In preparation for removal of static setup of IRQ resource from DT core
> code use platform_get_irq().
>
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>

Reviewed-by: Andrzej Hajda <andrzej.hajda@intel.com>

Regards

Andrzej

> ---
> drivers/media/platform/s5p-mfc/s5p_mfc.c | 11 ++++-------
> 1 file changed, 4 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc.c b/drivers/media/platform/s5p-mfc/s5p_mfc.c
> index f6732f031e96..761341934925 100644
> --- a/drivers/media/platform/s5p-mfc/s5p_mfc.c
> +++ b/drivers/media/platform/s5p-mfc/s5p_mfc.c
> @@ -1268,7 +1268,6 @@ static int s5p_mfc_probe(struct platform_device *pdev)
> {
> struct s5p_mfc_dev *dev;
> struct video_device *vfd;
> - struct resource *res;
> int ret;
>
> pr_debug("%s++\n", __func__);
> @@ -1294,12 +1293,10 @@ static int s5p_mfc_probe(struct platform_device *pdev)
> if (IS_ERR(dev->regs_base))
> return PTR_ERR(dev->regs_base);
>
> - res = platform_get_resource(pdev, IORESOURCE_IRQ, 0);
> - if (!res) {
> - dev_err(&pdev->dev, "failed to get irq resource\n");
> - return -ENOENT;
> - }
> - dev->irq = res->start;
> + ret = platform_get_irq(pdev, 0);
> + if (ret < 0)
> + return ret;
> + dev->irq = ret;
> ret = devm_request_irq(&pdev->dev, dev->irq, s5p_mfc_irq,
> 0, pdev->name, dev);
> if (ret) {

\
 
 \ /
  Last update: 2021-12-28 09:42    [W:0.157 / U:0.496 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site