lkml.org 
[lkml]   [2021]   [Dec]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
Subject[csky-linux:riscv_compat_v2 17/17] arch/riscv/kernel/compat_signal.c:199:5: warning: no previous prototype for function 'compat_setup_rt_frame'
Hi Guo,

First bad commit (maybe != root cause):

tree: https://github.com/c-sky/csky-linux riscv_compat_v2
head: 750f87086bdd630f80b9bc3581bc3f329ef20f53
commit: 750f87086bdd630f80b9bc3581bc3f329ef20f53 [17/17] riscv: compat: Add COMPAT Kbuild skeletal support
config: riscv-buildonly-randconfig-r002-20211228 (https://download.01.org/0day-ci/archive/20211229/202112290250.xtdytZe1-lkp@intel.com/config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 7171af744543433ac75b232eb7dfdaef7efd4d7a)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install riscv cross compiling tool for clang build
# apt-get install binutils-riscv64-linux-gnu
# https://github.com/c-sky/csky-linux/commit/750f87086bdd630f80b9bc3581bc3f329ef20f53
git remote add csky-linux https://github.com/c-sky/csky-linux
git fetch --no-tags csky-linux riscv_compat_v2
git checkout 750f87086bdd630f80b9bc3581bc3f329ef20f53
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=riscv SHELL=/bin/bash arch/riscv/kernel/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> arch/riscv/kernel/compat_signal.c:199:5: warning: no previous prototype for function 'compat_setup_rt_frame' [-Wmissing-prototypes]
int compat_setup_rt_frame(struct ksignal *ksig, sigset_t *set,
^
arch/riscv/kernel/compat_signal.c:199:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
int compat_setup_rt_frame(struct ksignal *ksig, sigset_t *set,
^
static
1 warning generated.


vim +/compat_setup_rt_frame +199 arch/riscv/kernel/compat_signal.c

520279d27c28fd Guo Ren 2021-12-13 198
520279d27c28fd Guo Ren 2021-12-13 @199 int compat_setup_rt_frame(struct ksignal *ksig, sigset_t *set,
520279d27c28fd Guo Ren 2021-12-13 200 struct pt_regs *regs)
520279d27c28fd Guo Ren 2021-12-13 201 {
520279d27c28fd Guo Ren 2021-12-13 202 struct compat_rt_sigframe __user *frame;
520279d27c28fd Guo Ren 2021-12-13 203 long err = 0;
520279d27c28fd Guo Ren 2021-12-13 204
520279d27c28fd Guo Ren 2021-12-13 205 frame = compat_get_sigframe(ksig, regs, sizeof(*frame));
520279d27c28fd Guo Ren 2021-12-13 206 if (!access_ok(frame, sizeof(*frame)))
520279d27c28fd Guo Ren 2021-12-13 207 return -EFAULT;
520279d27c28fd Guo Ren 2021-12-13 208
520279d27c28fd Guo Ren 2021-12-13 209 err |= copy_siginfo_to_user32(&frame->info, &ksig->info);
520279d27c28fd Guo Ren 2021-12-13 210
520279d27c28fd Guo Ren 2021-12-13 211 /* Create the ucontext. */
520279d27c28fd Guo Ren 2021-12-13 212 err |= __put_user(0, &frame->uc.uc_flags);
520279d27c28fd Guo Ren 2021-12-13 213 err |= __put_user(NULL, &frame->uc.uc_link);
520279d27c28fd Guo Ren 2021-12-13 214 err |= __compat_save_altstack(&frame->uc.uc_stack, regs->sp);
520279d27c28fd Guo Ren 2021-12-13 215 err |= compat_setup_sigcontext(frame, regs);
520279d27c28fd Guo Ren 2021-12-13 216 err |= __copy_to_user(&frame->uc.uc_sigmask, set, sizeof(*set));
520279d27c28fd Guo Ren 2021-12-13 217 if (err)
520279d27c28fd Guo Ren 2021-12-13 218 return -EFAULT;
520279d27c28fd Guo Ren 2021-12-13 219
520279d27c28fd Guo Ren 2021-12-13 220 regs->ra = (unsigned long)COMPAT_VDSO_SYMBOL(
520279d27c28fd Guo Ren 2021-12-13 221 current->mm->context.vdso, rt_sigreturn);
520279d27c28fd Guo Ren 2021-12-13 222
520279d27c28fd Guo Ren 2021-12-13 223 /*
520279d27c28fd Guo Ren 2021-12-13 224 * Set up registers for signal handler.
520279d27c28fd Guo Ren 2021-12-13 225 * Registers that we don't modify keep the value they had from
520279d27c28fd Guo Ren 2021-12-13 226 * user-space at the time we took the signal.
520279d27c28fd Guo Ren 2021-12-13 227 * We always pass siginfo and mcontext, regardless of SA_SIGINFO,
520279d27c28fd Guo Ren 2021-12-13 228 * since some things rely on this (e.g. glibc's debug/segfault.c).
520279d27c28fd Guo Ren 2021-12-13 229 */
520279d27c28fd Guo Ren 2021-12-13 230 regs->epc = (unsigned long)ksig->ka.sa.sa_handler;
520279d27c28fd Guo Ren 2021-12-13 231 regs->sp = (unsigned long)frame;
520279d27c28fd Guo Ren 2021-12-13 232 regs->a0 = ksig->sig; /* a0: signal number */
520279d27c28fd Guo Ren 2021-12-13 233 regs->a1 = (unsigned long)(&frame->info); /* a1: siginfo pointer */
520279d27c28fd Guo Ren 2021-12-13 234 regs->a2 = (unsigned long)(&frame->uc); /* a2: ucontext pointer */
520279d27c28fd Guo Ren 2021-12-13 235

:::::: The code at line 199 was first introduced by commit
:::::: 520279d27c28fd0bcabaef85d9c71cb592da21c2 riscv: compat: signal: Add rt_frame implementation

:::::: TO: Guo Ren <guoren@linux.alibaba.com>
:::::: CC: Guo Ren <guoren@linux.alibaba.com>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

\
 
 \ /
  Last update: 2021-12-28 19:46    [W:0.029 / U:4.532 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site