lkml.org 
[lkml]   [2021]   [Dec]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH v19 04/13] kdump: reduce unnecessary parameters of parse_crashkernel_{high|low}()
Date
Delete confusing parameters 'system_ram' and 'crash_base' of
parse_crashkernel_{high|low}(), they are only needed by the case of
"crashkernel=X@[offset]".

Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
---
kernel/crash_core.c | 21 ++++++++++-----------
1 file changed, 10 insertions(+), 11 deletions(-)

diff --git a/kernel/crash_core.c b/kernel/crash_core.c
index 3b9e01fc450b2a4..b7d024eb464d0ae 100644
--- a/kernel/crash_core.c
+++ b/kernel/crash_core.c
@@ -278,20 +278,20 @@ int __init parse_crashkernel(char *cmdline,
}

static int __init parse_crashkernel_high(char *cmdline,
- unsigned long long system_ram,
- unsigned long long *crash_size,
- unsigned long long *crash_base)
+ unsigned long long *crash_size)
{
- return __parse_crashkernel(cmdline, system_ram, crash_size, crash_base,
+ unsigned long long base;
+
+ return __parse_crashkernel(cmdline, 0, crash_size, &base,
"crashkernel=", suffix_tbl[SUFFIX_HIGH]);
}

static int __init parse_crashkernel_low(char *cmdline,
- unsigned long long system_ram,
- unsigned long long *crash_size,
- unsigned long long *crash_base)
+ unsigned long long *crash_size)
{
- return __parse_crashkernel(cmdline, system_ram, crash_size, crash_base,
+ unsigned long long base;
+
+ return __parse_crashkernel(cmdline, 0, crash_size, &base,
"crashkernel=", suffix_tbl[SUFFIX_LOW]);
}

@@ -310,12 +310,11 @@ int __init parse_crashkernel_high_low(char *cmdline,
unsigned long long *low_size)
{
int ret;
- unsigned long long base;

BUG_ON(!high_size || !low_size);

/* crashkernel=X,high */
- ret = parse_crashkernel_high(cmdline, 0, high_size, &base);
+ ret = parse_crashkernel_high(cmdline, high_size);
if (ret)
return ret;

@@ -323,7 +322,7 @@ int __init parse_crashkernel_high_low(char *cmdline,
return -EINVAL;

/* crashkernel=Y,low */
- ret = parse_crashkernel_low(cmdline, 0, low_size, &base);
+ ret = parse_crashkernel_low(cmdline, low_size);
if (ret)
*low_size = -1;

--
2.25.1
\
 
 \ /
  Last update: 2021-12-28 14:30    [W:0.864 / U:0.008 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site