lkml.org 
[lkml]   [2021]   [Dec]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v1 19/23] cachefiles: implement .demand_read() for demand read
From


On 12/27/21 11:36 PM, Matthew Wilcox wrote:
> On Mon, Dec 27, 2021 at 08:54:40PM +0800, Jeffle Xu wrote:
>> + spin_lock(&cache->reqs_lock);
>> + ret = idr_alloc(&cache->reqs, req, 0, 0, GFP_KERNEL);
>
> GFP_KERNEL while holding a spinlock?

Right. Thanks for pointing it out.

>
> You should be using an XArray instead of an IDR in new code anyway.
>

Regards.

--
Thanks,
Jeffle

\
 
 \ /
  Last update: 2021-12-28 13:34    [W:0.087 / U:0.344 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site