lkml.org 
[lkml]   [2021]   [Dec]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] kobject: remove kset from struct kset_uevent_ops callbacks
On Mon, Dec 27, 2021 at 08:41:36PM +0000, Wedson Almeida Filho wrote:
> On Mon, Dec 27, 2021 at 05:39:24PM +0100, Greg Kroah-Hartman wrote:
> > There is no need to pass the pointer to the kset in the struct
> > kset_uevent_ops callbacks as no one uses it, so just remove that pointer
> > entirely.
>
> In the future, if someone needs the kset they can always find it by looking for
> the first non-null kset in the kobject or its parent chain, right? IOW, we're
> not losing any information by removing this.

Or even easier, we can add it back if needed :)

> >
> > Cc: Rafael J. Wysocki <rafael@kernel.org>
> > Cc: Wedson Almeida Filho <wedsonaf@google.com>
> > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>
> Reviewed-by: Wedson Almeida Filho <wedsonaf@google.com>

Thanks for the review.

greg k-h

\
 
 \ /
  Last update: 2021-12-28 11:08    [W:0.038 / U:0.976 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site