[lkml]   [2021]   [Dec]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH v3 3/3] blk-crypto: show crypto capabilities in sysfs
On Fri, Dec 10, 2021 at 09:29:41AM -0800, Bart Van Assche wrote:
> On 12/9/21 10:42 PM, Greg Kroah-Hartman wrote:
> > A single hex value makes sense to me.
> Hi Greg,
> I'm not enthusiast about this approach because:
> (a) A single hex value can be confused with a number. Reporting a bitfield in
> hex format is not sufficient to prevent confusion with a number.

Each sysfs file has their own "units" or values, or whatever. So a hex
number or bitfield or something else is fine.

Again, single value, no need to parse, is the key here.

> (b) No other block layer sysfs attribute follows this encoding scheme.

Then follow what they do. Do they have multiple values in a single
file? If so, they are broken and we should change that.

> (c) This encoding enforces the restriction that data unit sizes are a power of
> two. Is there anything fundamental in encryption that restricts data unit
> sizes to a power of two? I don't know the answer myself.

Again, you all can pick the rules you want for this file, if you want to
have bitfields, wonderful! If you want to make it an enum, wonderful!


greg k-h

 \ /
  Last update: 2021-12-11 11:50    [W:0.093 / U:0.972 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site