lkml.org 
[lkml]   [2021]   [Dec]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
Subjectarch/powerpc/mm/ptdump/hashpagetable.c:264:29: sparse: sparse: restricted __be64 degrades to integer
Hi Christophe,

First bad commit (maybe != root cause):

tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: c741e49150dbb0c0aebe234389f4aa8b47958fa8
commit: e084728393a58e7fdafeee2e6b20e0faff09b557 powerpc/ptdump: Convert powerpc to GENERIC_PTDUMP
date: 4 months ago
config: powerpc64-randconfig-s031-20211210 (https://download.01.org/0day-ci/archive/20211210/202112101832.rZbrZJ1u-lkp@intel.com/config)
compiler: powerpc64-linux-gcc (GCC) 11.2.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# apt-get install sparse
# sparse version: v0.6.4-dirty
# https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=e084728393a58e7fdafeee2e6b20e0faff09b557
git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
git fetch --no-tags linus master
git checkout e084728393a58e7fdafeee2e6b20e0faff09b557
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=powerpc SHELL=/bin/bash arch/powerpc/mm/ptdump/ kernel/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>


sparse warnings: (new ones prefixed by >>)
>> arch/powerpc/mm/ptdump/hashpagetable.c:264:29: sparse: sparse: restricted __be64 degrades to integer
arch/powerpc/mm/ptdump/hashpagetable.c:265:49: sparse: sparse: restricted __be64 degrades to integer
>> arch/powerpc/mm/ptdump/hashpagetable.c:267:36: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned long long [usertype] @@ got restricted __be64 [usertype] v @@
arch/powerpc/mm/ptdump/hashpagetable.c:267:36: sparse: expected unsigned long long [usertype]
arch/powerpc/mm/ptdump/hashpagetable.c:267:36: sparse: got restricted __be64 [usertype] v
>> arch/powerpc/mm/ptdump/hashpagetable.c:268:36: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned long long [usertype] @@ got restricted __be64 [usertype] r @@
arch/powerpc/mm/ptdump/hashpagetable.c:268:36: sparse: expected unsigned long long [usertype]
arch/powerpc/mm/ptdump/hashpagetable.c:268:36: sparse: got restricted __be64 [usertype] r

vim +264 arch/powerpc/mm/ptdump/hashpagetable.c

1515ab93215625 arch/powerpc/mm/dump_hashpagetable.c Rashmica Gupta 2016-05-27 238
1515ab93215625 arch/powerpc/mm/dump_hashpagetable.c Rashmica Gupta 2016-05-27 239 static int pseries_find(unsigned long ea, int psize, bool primary, u64 *v, u64 *r)
1515ab93215625 arch/powerpc/mm/dump_hashpagetable.c Rashmica Gupta 2016-05-27 240 {
1515ab93215625 arch/powerpc/mm/dump_hashpagetable.c Rashmica Gupta 2016-05-27 241 struct hash_pte ptes[4];
1515ab93215625 arch/powerpc/mm/dump_hashpagetable.c Rashmica Gupta 2016-05-27 242 unsigned long vsid, vpn, hash, hpte_group, want_v;
1515ab93215625 arch/powerpc/mm/dump_hashpagetable.c Rashmica Gupta 2016-05-27 243 int i, j, ssize = mmu_kernel_ssize;
1515ab93215625 arch/powerpc/mm/dump_hashpagetable.c Rashmica Gupta 2016-05-27 244 long lpar_rc = 0;
1515ab93215625 arch/powerpc/mm/dump_hashpagetable.c Rashmica Gupta 2016-05-27 245 unsigned long shift = mmu_psize_defs[psize].shift;
1515ab93215625 arch/powerpc/mm/dump_hashpagetable.c Rashmica Gupta 2016-05-27 246
1515ab93215625 arch/powerpc/mm/dump_hashpagetable.c Rashmica Gupta 2016-05-27 247 /* calculate hash */
1515ab93215625 arch/powerpc/mm/dump_hashpagetable.c Rashmica Gupta 2016-05-27 248 vsid = get_kernel_vsid(ea, ssize);
1515ab93215625 arch/powerpc/mm/dump_hashpagetable.c Rashmica Gupta 2016-05-27 249 vpn = hpt_vpn(ea, vsid, ssize);
1515ab93215625 arch/powerpc/mm/dump_hashpagetable.c Rashmica Gupta 2016-05-27 250 hash = hpt_hash(vpn, shift, ssize);
1515ab93215625 arch/powerpc/mm/dump_hashpagetable.c Rashmica Gupta 2016-05-27 251 want_v = hpte_encode_avpn(vpn, psize, ssize);
1515ab93215625 arch/powerpc/mm/dump_hashpagetable.c Rashmica Gupta 2016-05-27 252
1515ab93215625 arch/powerpc/mm/dump_hashpagetable.c Rashmica Gupta 2016-05-27 253 /* to check in the secondary hash table, we invert the hash */
1515ab93215625 arch/powerpc/mm/dump_hashpagetable.c Rashmica Gupta 2016-05-27 254 if (!primary)
1515ab93215625 arch/powerpc/mm/dump_hashpagetable.c Rashmica Gupta 2016-05-27 255 hash = ~hash;
1531cff44b5bb3 arch/powerpc/mm/dump_hashpagetable.c Aneesh Kumar K.V 2018-06-29 256 hpte_group = (hash & htab_hash_mask) * HPTES_PER_GROUP;
1515ab93215625 arch/powerpc/mm/dump_hashpagetable.c Rashmica Gupta 2016-05-27 257 /* see if we can find an entry in the hpte with this hash */
1515ab93215625 arch/powerpc/mm/dump_hashpagetable.c Rashmica Gupta 2016-05-27 258 for (i = 0; i < HPTES_PER_GROUP; i += 4, hpte_group += 4) {
1515ab93215625 arch/powerpc/mm/dump_hashpagetable.c Rashmica Gupta 2016-05-27 259 lpar_rc = plpar_pte_read_4(0, hpte_group, (void *)ptes);
1515ab93215625 arch/powerpc/mm/dump_hashpagetable.c Rashmica Gupta 2016-05-27 260
7c466b0807960e arch/powerpc/mm/ptdump/hashpagetable.c Christophe Leroy 2020-06-15 261 if (lpar_rc)
1515ab93215625 arch/powerpc/mm/dump_hashpagetable.c Rashmica Gupta 2016-05-27 262 continue;
1515ab93215625 arch/powerpc/mm/dump_hashpagetable.c Rashmica Gupta 2016-05-27 263 for (j = 0; j < 4; j++) {
1515ab93215625 arch/powerpc/mm/dump_hashpagetable.c Rashmica Gupta 2016-05-27 @264 if (HPTE_V_COMPARE(ptes[j].v, want_v) &&
1515ab93215625 arch/powerpc/mm/dump_hashpagetable.c Rashmica Gupta 2016-05-27 265 (ptes[j].v & HPTE_V_VALID)) {
1515ab93215625 arch/powerpc/mm/dump_hashpagetable.c Rashmica Gupta 2016-05-27 266 /* HPTE matches */
1515ab93215625 arch/powerpc/mm/dump_hashpagetable.c Rashmica Gupta 2016-05-27 @267 *v = ptes[j].v;
1515ab93215625 arch/powerpc/mm/dump_hashpagetable.c Rashmica Gupta 2016-05-27 @268 *r = ptes[j].r;
1515ab93215625 arch/powerpc/mm/dump_hashpagetable.c Rashmica Gupta 2016-05-27 269 return 0;
1515ab93215625 arch/powerpc/mm/dump_hashpagetable.c Rashmica Gupta 2016-05-27 270 }
1515ab93215625 arch/powerpc/mm/dump_hashpagetable.c Rashmica Gupta 2016-05-27 271 }
1515ab93215625 arch/powerpc/mm/dump_hashpagetable.c Rashmica Gupta 2016-05-27 272 }
1515ab93215625 arch/powerpc/mm/dump_hashpagetable.c Rashmica Gupta 2016-05-27 273 return -1;
1515ab93215625 arch/powerpc/mm/dump_hashpagetable.c Rashmica Gupta 2016-05-27 274 }
1515ab93215625 arch/powerpc/mm/dump_hashpagetable.c Rashmica Gupta 2016-05-27 275

:::::: The code at line 264 was first introduced by commit
:::::: 1515ab932156257afd8a5864506dab80f63ff38b powerpc/mm: Dump hash table

:::::: TO: Rashmica Gupta <rashmicy@gmail.com>
:::::: CC: Michael Ellerman <mpe@ellerman.id.au>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

\
 
 \ /
  Last update: 2021-12-10 12:05    [W:0.038 / U:6.028 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site